Run CI / CodeQL / Dependency Review on develop pull requests#191
Closed
kirich1409 wants to merge 1 commit into
Closed
Run CI / CodeQL / Dependency Review on develop pull requests#191kirich1409 wants to merge 1 commit into
kirich1409 wants to merge 1 commit into
Conversation
The repo uses a main (released) + develop (integration) branching model. The develop ruleset requires status checks Build Android, Build Docs, and Build iOS, but the workflows producing those checks were configured to trigger only on pull_request.branches: [main], so PRs targeting develop never ran them and were permanently merge-blocked. Add develop to the pull_request.branches list of ci.yml, docs.yml, codeql.yml, and dependency-review.yml. Add develop to push.branches for ci.yml and codeql.yml as well (post-merge integration validation). Leave docs.yml push.branches at main-only — the publish-docs job gates on github.event_name == 'push' and publishes to GitHub Pages, which must remain main-only. publish.yml stays main-only. No job, step, action, runner, permission, or concurrency change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The repo uses main (released code) + develop (integration). The
developruleset requires status checksBuild Android,Build Docs, andBuild iOS, but the workflows producing those checks are configured withpull_request.branches: [ main ]only. PRs targetingdevelop(e.g. #190) therefore never run the required checks and stay inmergeStateStatus: BLOCKEDforever.What
Add
developto PR triggers (and post-merge push triggers where appropriate) in four workflow files:push.branchespull_request.branches.github/workflows/ci.yml[ main, develop ][ main, develop ].github/workflows/codeql.yml[ main, develop ][ main, develop ].github/workflows/dependency-review.yml[ main, develop ].github/workflows/docs.yml- developdocs.ymlkeepspush.branches: [ main ]because thepublish-docsjob gates ongithub.event_name == 'push'and pushes to GitHub Pages — Pages must stay main-only.publish.yml(Maven Central) is left untouched, also intentionally main-only.No job step, action version, runner, permission, or concurrency group changed.
Verification
Once this PR lands in develop, re-trigger checks on #190 by either closing+reopening it or pushing an empty commit; the
Build Android/Build Docs/Build iOSjobs will then register and unblock the merge.Test plan
Build Androidruns on this PR (proves the trigger fix works for develop PRs).Build Docsruns.Build iOSruns (macOS runner).CodeQLAnalyze Kotlin runs.dependency-reviewruns.🤖 Generated with Claude Code